Add -config flag #18
Add -config flag #18
Conversation
| case 2: | ||
| cmd = os.Args[1] | ||
| case 4: | ||
| cmd = os.Args[3] |
There was a problem hiding this comment.
This is something I'm not a huge fan of; because it's guessing whether the config flag comes before or after the command.
| func ReadConfig(config_path string) (Config, error) { | ||
| var config Config | ||
| configPath := getConfigPath() | ||
| configPath := getConfigPath(config_path) |
There was a problem hiding this comment.
In Golang I use camelCase instead of underscores for variables (as is mentioned in Google's style guide).
| func getConfigPath(config_path string) string { | ||
| if FileExists(config_path) { | ||
| return config_path | ||
| } else { | ||
| dirname, _ := os.UserHomeDir() | ||
| return dirname + "/.mdrss/config.json" | ||
| } |
There was a problem hiding this comment.
I check for the existence of the config path later in the code. Here I just select / construct the config path that I want to use. Hence. the first if statement should only check whether the config path from the flag is enabled.
(PS: it should not be called configPath yet, because we don't know whether it is even used at this point. It's really the config path flag).
There was a problem hiding this comment.
I'd also add that XDG should be used. So this should be ~/.config/mdrss/config.json.
Instead of:
dirname, _ := os.UserHomeDir()
return dirname + "/.mdrss/config.json"you can use adrg/xdg:
configFilePath, err := xdg.ConfigFile("mdrss/config.json")
if err != nil {
log.Fatal(err)
}
return configFilePath
|
Hi @TimoKats, I'll leave the PR in your hands to change the way you like before merge. |
|
Hi @yonas . Thanks will do |
Allow users to specify path to
config.json.